From c2892f82e1d4d5ed046f4ee9cf1955bb97f27021 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roman=20Smr=C5=BE?= Date: Sat, 6 Feb 2021 21:40:07 +0100 Subject: Avoid unnecessary copying in range loops --- src/channel.cpp | 4 ++-- src/identity.cpp | 2 +- src/message.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/channel.cpp b/src/channel.cpp index b13a71e..787fb08 100644 --- a/src/channel.cpp +++ b/src/channel.cpp @@ -14,7 +14,7 @@ Ref ChannelRequestData::store(const Storage & st) const { vector items; - for (const auto p : peers) + for (const auto & p : peers) items.emplace_back("peer", p); items.emplace_back("enc", "aes-128-gcm"); items.emplace_back("key", key); @@ -94,7 +94,7 @@ Ref Channel::store(const Storage & st) const { vector items; - for (const auto p : peers) + for (const auto & p : peers) items.emplace_back("peer", p); items.emplace_back("enc", "aes-128-gcm"); items.emplace_back("key", key); diff --git a/src/identity.cpp b/src/identity.cpp index fe4cf53..374a872 100644 --- a/src/identity.cpp +++ b/src/identity.cpp @@ -177,7 +177,7 @@ Ref IdentityData::store(const Storage & st) const { vector items; - for (const auto p : prev) + for (const auto & p : prev) items.emplace_back("SPREV", p.ref()); if (name) items.emplace_back("name", *name); diff --git a/src/message.cpp b/src/message.cpp index f8e0d96..eb1212c 100644 --- a/src/message.cpp +++ b/src/message.cpp @@ -73,7 +73,7 @@ Ref DirectMessageData::store(const Storage & st) const { vector items; - for (const auto prev : prev) + for (const auto & prev : prev) items.emplace_back("PREV", prev.ref()); if (from) items.emplace_back("from", from->ref().value()); -- cgit v1.2.3